pipexerp/ai-proj-helper
8
0
Fork 0
Code Issues Pull Requests 2 Actions Packages Projects Releases Wiki Activity

feat(skills): make Codex the default install target

Browse Source
This commit is contained in:
qiudl
2026-08-20 12:07:10 +09:30
parent ef0e9ca1f0
commit bb5e6be73e
7 changed files with 139 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/install-skills.test.sh
+47 -11
View File
@@ -13,10 +13,10 @@ mkdir -p "$TEST_HOME"
cp "$PROJECT_DIR/install-skills.sh" "$FIXTURE_REPO/install-skills.sh"
write_manifest() {
local plugin="$1" name="$2" version="$3"
local plugin="$1" name="$2" version="$3" install_type="${4:-skill}"
mkdir -p "$FIXTURE_REPO/skills-dev/${plugin}-plugin/.claude-plugin"
cat > "$FIXTURE_REPO/skills-dev/${plugin}-plugin/.claude-plugin/plugin.json" <<JSON
{"name":"${plugin}-plugin","version":"${version}","install_name":"${name}","install_type":"skill","dir_category":"dev"}
{"name":"${plugin}-plugin","version":"${version}","install_name":"${name}","install_type":"${install_type}","dir_category":"dev"}
JSON
}
@@ -31,7 +31,7 @@ EOF
printf 'reference one\n' > "$FIXTURE_REPO/skills-dev/example-plugin/skills/references/guide.md"
HOME="$TEST_HOME" "$FIXTURE_REPO/install-skills.sh" >/dev/null
test -f "$TEST_HOME/.claude/skills/example/references/guide.md"
test -f "$TEST_HOME/.agents/skills/example/references/guide.md"
# A repository version upgrade replaces an unchanged prior install.
write_manifest example example 2.0.0
@@ -43,17 +43,17 @@ description: Installer fixture version two.
version two
EOF
HOME="$TEST_HOME" "$FIXTURE_REPO/install-skills.sh" >/dev/null
grep -q 'version two' "$TEST_HOME/.claude/skills/example/SKILL.md"
grep -q '"version": "2.0.0"' "$TEST_HOME/.claude/.installed-skills.json"
grep -q 'version two' "$TEST_HOME/.agents/skills/example/SKILL.md"
grep -q '"version": "2.0.0"' "$TEST_HOME/.agents/.ai-proj-helper-installed-skills.json"
# A local edit is preserved even when the repository advances again.
printf 'local edit\n' >> "$TEST_HOME/.claude/skills/example/SKILL.md"
printf 'local edit\n' >> "$TEST_HOME/.agents/skills/example/SKILL.md"
write_manifest example example 3.0.0
printf 'repository version three\n' >> "$FIXTURE_REPO/skills-dev/example-plugin/skills/SKILL.md"
output="$(HOME="$TEST_HOME" "$FIXTURE_REPO/install-skills.sh")"
grep -q 'local files were modified' <<<"$output"
grep -q 'local edit' "$TEST_HOME/.claude/skills/example/SKILL.md"
if grep -q 'repository version three' "$TEST_HOME/.claude/skills/example/SKILL.md"; then
grep -q 'local edit' "$TEST_HOME/.agents/skills/example/SKILL.md"
if grep -q 'repository version three' "$TEST_HOME/.agents/skills/example/SKILL.md"; then
echo 'local modification was overwritten' >&2
exit 1
fi
@@ -70,9 +70,45 @@ description: Legacy installation fixture.
legacy content
EOF
printf 'legacy reference\n' > "$FIXTURE_REPO/skills-dev/legacy-plugin/skills/references/guide.md"
mkdir -p "$TEST_HOME/.claude/skills/legacy"
cp "$FIXTURE_REPO/skills-dev/legacy-plugin/skills/SKILL.md" "$TEST_HOME/.claude/skills/legacy/SKILL.md"
mkdir -p "$TEST_HOME/.agents/skills/legacy"
cp "$FIXTURE_REPO/skills-dev/legacy-plugin/skills/SKILL.md" "$TEST_HOME/.agents/skills/legacy/SKILL.md"
HOME="$TEST_HOME" "$FIXTURE_REPO/install-skills.sh" >/dev/null
test -f "$TEST_HOME/.claude/skills/legacy/references/guide.md"
test -f "$TEST_HOME/.agents/skills/legacy/references/guide.md"
# Command manifests become standard Codex skills, while explicit Claude
# installs retain the legacy single-file command layout. Both must be stable on
# a second run despite the Claude filename change.
write_manifest sample-command sample-command 1.0.0 command
mkdir -p "$FIXTURE_REPO/skills-dev/sample-command-plugin/skills"
cat > "$FIXTURE_REPO/skills-dev/sample-command-plugin/skills/SKILL.md" <<'EOF'
---
name: sample-command
description: Command installation fixture.
---
command content
EOF
CODEX_TEST_HOME="$TEST_ROOT/codex-home"
mkdir -p "$CODEX_TEST_HOME"
HOME="$CODEX_TEST_HOME" "$FIXTURE_REPO/install-skills.sh" >/dev/null
test -f "$CODEX_TEST_HOME/.agents/skills/sample-command/SKILL.md"
test ! -e "$CODEX_TEST_HOME/.claude/commands/sample-command.md"
codex_output="$(HOME="$CODEX_TEST_HOME" "$FIXTURE_REPO/install-skills.sh" --dry-run)"
grep -q '0 plugins would be installed/updated' <<<"$codex_output"
if grep -q 'sample-command: local files were modified' <<<"$codex_output"; then
echo 'Codex command skill was reported as modified' >&2
exit 1
fi
CLAUDE_TEST_HOME="$TEST_ROOT/claude-home"
mkdir -p "$CLAUDE_TEST_HOME"
HOME="$CLAUDE_TEST_HOME" "$FIXTURE_REPO/install-skills.sh" --agent claude >/dev/null
test -f "$CLAUDE_TEST_HOME/.claude/commands/sample-command.md"
claude_output="$(HOME="$CLAUDE_TEST_HOME" "$FIXTURE_REPO/install-skills.sh" --agent claude --dry-run)"
grep -q '0 plugins would be installed/updated' <<<"$claude_output"
if grep -q 'sample-command: local files were modified' <<<"$claude_output"; then
echo 'Claude command was reported as modified after filename conversion' >&2
exit 1
fi
echo 'install-skills tests passed'